-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Add note about dotnet restore in README #1692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Marking as WIP to check if there are any more locations where this update should be done. |
|
This is ready to review. |
framework/libraries/README.md
Outdated
| The project under `/new-library` targets **only** .NET Core. For that reason, | ||
| this project is stored under the core project directory, so our build server builds it on | ||
| all platforms. Look under https://github.com/dotnet/samples/tree/master/core/libraries/new-library/. | ||
| all platforms. Look under https://github.com/dotnet/samples/tree/master/core/libraries/new-library/. <!-- TODO: THIS LINK IS DEAD !! --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link here needs to be updated, I don't know what it should be currently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And also a small note @mairaw, similar cases should be taken into consideration when addressing dotnet/docs#14825, the automated solution should look in samples readme files too, not only look in dotnet/docs and dotnet/dotnet-api-docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking through this, I think the right fix now is to remove the "new-library" section from this readme file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these updates @Youssef1313
This is ready to
now.
No description provided.