Skip to content

Conversation

@Youssef1313
Copy link
Member

No description provided.

@Youssef1313 Youssef1313 changed the title Add note about dotnet restore in README WIP Add note about dotnet restore in README Nov 2, 2019
@Youssef1313
Copy link
Member Author

Marking as WIP to check if there are any more locations where this update should be done.

@Youssef1313 Youssef1313 changed the title WIP Add note about dotnet restore in README dd note about dotnet restore in README Nov 2, 2019
@Youssef1313 Youssef1313 changed the title dd note about dotnet restore in README Add note about dotnet restore in README Nov 2, 2019
@Youssef1313
Copy link
Member Author

This is ready to review.

The project under `/new-library` targets **only** .NET Core. For that reason,
this project is stored under the core project directory, so our build server builds it on
all platforms. Look under https://github.com/dotnet/samples/tree/master/core/libraries/new-library/.
all platforms. Look under https://github.com/dotnet/samples/tree/master/core/libraries/new-library/. <!-- TODO: THIS LINK IS DEAD !! -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link here needs to be updated, I don't know what it should be currently.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After browsing in the history, found that it was deleted in #494.
Should they be added back ? @mairaw .
If so, should I add them back in this PR or a separate one ?

Copy link
Member Author

@Youssef1313 Youssef1313 Nov 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also a small note @mairaw, similar cases should be taken into consideration when addressing dotnet/docs#14825, the automated solution should look in samples readme files too, not only look in dotnet/docs and dotnet/dotnet-api-docs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking through this, I think the right fix now is to remove the "new-library" section from this readme file.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates @Youssef1313

This is ready to :shipit: now.

@BillWagner BillWagner merged commit 4d4a3a9 into dotnet:master Nov 5, 2019
@Youssef1313 Youssef1313 deleted the patch-4 branch November 5, 2019 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants